[Contribution] Document the different types of tests run in CI #15491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
reviewed
Jul 6, 2021
OskarStark
approved these changes
Jul 6, 2021
OskarStark
reviewed
Jul 6, 2021
| A failure in this job indicates a bug in the communication with these | ||
| services. | ||
|
|
||
| ``PHPUnit / Tests (experimental)`` |
There was a problem hiding this comment.
Do we really need to run this job then on PRs?
Maybe we can run this if we add a dedicated label "experimental ci"?
There was a problem hiding this comment.
we need to have it run on PRs, otherwise we cannot improve the state of those tests
wouterj
commented
Jul 6, 2021
|
Thank you Wouter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is two sided:
symfony/symfonyworkflows@nicolas-grekas I would love if you could have a look if I'm not talking nonsense here 😄