[Mercure] Remove wrong parameter in MockHub #15782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotbruneel
changed the title
dunglas
approved these changes
Sep 16, 2021
carsonbot
changed the title
carsonbot
changed the title
There is no parameter in `MockHub` to specify the hub name (`default`) `MockHub` constructor : https://github.com/symfony/mercure/blob/main/src/MockHub.php#L30-L35 ```php /** * @param (callable(Update): string) $publisher */ public function __construct( string $url, TokenProviderInterface $jwtProvider, callable $publisher, TokenFactoryInterface $jwtFactory = null, string $publicUrl = null ) ```
javiereguiluz
force-pushed
the
patch-4
branch
from
771e7ac to
28cbc5d
Compare
|
Good catch, thanks Elliot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no parameter in
MockHubto specify the hub name (default)MockHubconstructor : https://github.com/symfony/mercure/blob/main/src/MockHub.php#L30-L35