Adding Upgrading Section #15979
Closed
Adding Upgrading Section #15979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This text is (somewhat) a duplicate of https://symfony.com/doc/current/form/bootstrap5.html#error-messages - if you agree *in principle* that adding an upgrade section is a good idea, I'll see if I can improve this. Second list item would be to remove all `radio-custom`, `checkbox-custom`, and `switch-custom` https://symfony.com/doc/current/form/bootstrap4.html#custom-forms Plus maybe a link to https://getbootstrap.com/docs/5.1/migration/
|
Linting error: The code block is meant to be indented (for the list) - what is the right syntax? |
|
Actually, the text isn't quite right. Since |
|
I'm closing this old issue as "won't fix". This is not wrong ... but would require a certain amount of maintenance work. So, let's do this only if we receive enough feedback from the community about this. So far, I think we didn't receive any comments here or in Symfony Slack chat. So, let's keep waiting for feedback. Thanks for understanding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This text is (somewhat) a duplicate of https://symfony.com/doc/current/form/bootstrap5.html#error-messages - if you agree in principle that adding an upgrade section is a good idea, I'll see if I can improve this.
Second list item would be to remove all
radio-custom,checkbox-custom, andswitch-customhttps://symfony.com/doc/current/form/bootstrap4.html#custom-formsPlus maybe a link to https://getbootstrap.com/docs/5.1/migration/