Skip to content

[Notifier] Remove Firebase transport from Push Channel list #16249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

ssitdikov
Copy link
Contributor

@ssitdikov ssitdikov commented Dec 14, 2021

FirebaseTransport supports ChatMessage and not supports TexterTransport which indicated in Documentation.

@ssitdikov ssitdikov changed the title Remove Firebase transport from Push Channel list [Notifier] Remove Firebase transport from Push Channel list Dec 25, 2021
Copy link
Contributor

@mdoutreluingne mdoutreluingne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes #16910
(note for the mergers: this can be merged in 5.4)

@carsonbot carsonbot changed the title [Notifier] Remove Firebase transport from Push Channel list Remove Firebase transport from Push Channel list Jun 25, 2022
@mdoutreluingne
Copy link
Contributor

@javiereguiluz friendly ping

@carsonbot carsonbot changed the title Remove Firebase transport from Push Channel list [Notifier] Remove Firebase transport from Push Channel list Jul 4, 2022
@javiereguiluz javiereguiluz added this to the 5.4 milestone Jul 4, 2022
FirebaseTransport supports ChatMessage and not supported by TexterTransport which indicated in Documentation.
@javiereguiluz
Copy link
Member

@ssitdikov thanks for fixing this and congrats on your first Symfony Docs contribution 🎉

@mdoutreluingne sorry for the late reply about this.

@javiereguiluz javiereguiluz merged commit 8108407 into symfony:5.4 Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants