Skip to content

[String] Fix doc for String #16539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2022
Merged

[String] Fix doc for String #16539

merged 1 commit into from
Feb 25, 2022

Conversation

nicolas-grekas
Copy link
Member

Fixing #16424
PREG_UNMATCHED_AS_NULL is already the default and cannot be disabled.

@carsonbot carsonbot added this to the 5.4 milestone Feb 23, 2022
wouterj
wouterj approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! +1 for also making it more concise

@carsonbot carsonbot changed the title Fix doc for String [String] Fix doc for String Feb 25, 2022
@javiereguiluz
Copy link
Member

Nice! Thanks for fixing the docs.

@javiereguiluz javiereguiluz merged commit 69992ab into symfony:5.4 Feb 25, 2022
@nicolas-grekas nicolas-grekas deleted the str-fix branch May 10, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Status: Reviewed String
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @javiereguiluz @wouterj @OskarStark @carsonbot