Skip to content

Conversation

mark2016
Copy link
Contributor

@mark2016 mark2016 commented Mar 7, 2022

Fix the line numbering of the description of the ProductController to correctly align with the described line (the second half of them were about 2 out).

Copy link
Contributor

@94noni 94noni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should target v5.4, as it is same rewrite it means

@carsonbot carsonbot changed the title Update doctrine.rst [Doctrine] Update doctrine.rst Mar 8, 2022
@javiereguiluz javiereguiluz added this to the 5.4 milestone Mar 8, 2022
@javiereguiluz
Copy link
Member

Good catch @mark2016 ! Thanks ... and congrats on your first Symfony Docs contribution 🎉

@94noni yes! We rebased to 5.4 while merging. Thanks!

@javiereguiluz javiereguiluz changed the base branch from 6.0 to 5.4 March 8, 2022 08:57
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner March 8, 2022 08:57
@javiereguiluz javiereguiluz merged commit e6ddcd2 into symfony:5.4 Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants