Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Encore] Add version support for the --public parameter and a small docker support section #16622

Closed
wants to merge 6 commits into from
Closed

Conversation

shadowc
Copy link

@shadowc shadowc commented Mar 17, 2022

Reflects changes in: symfony/webpack-encore#1095

Adds the version number at which this feature will be released, and it also adds a docker example for a nodejs box.

  • Test docker setup

@carsonbot carsonbot added this to the 5.4 milestone Mar 17, 2022
@louismariegaborit
Copy link
Contributor

louismariegaborit commented Mar 18, 2022

Could you update too the block example with a custom domain ?
To use HMR with custom domain, we must add --client-web-socket-url.
In the case of the doc, the option is --client-web-socket-url ws://app.vm:8080/ws and wss if https is enabled.

@shadowc
Copy link
Author

shadowc commented Mar 18, 2022

I think the doc only talks about "serving your files" from a custom domain (not having a custom HMR url), but we can definitely make that distinction and let people know about this other option!

@wouterj wouterj added the Encore label Oct 10, 2022
@carsonbot carsonbot changed the title Add version support for the --public parameter and a small docker support section [Encore] Add version support for the --public parameter and a small docker support section Oct 10, 2022
@shadowc shadowc closed this by deleting the head repository Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants