Skip to content

[Notifier] Add ContactEveryone Doc #16984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2022
Merged

[Notifier] Add ContactEveryone Doc #16984

merged 1 commit into from
Jul 18, 2022

Conversation

zairigimad
Copy link
Contributor

@zairigimad zairigimad commented Jul 15, 2022 •
edited
Loading

fix issue : #16915

@carsonbot carsonbot added this to the 6.2 milestone Jul 15, 2022
mdoutreluingne
mdoutreluingne approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@mdoutreluingne mdoutreluingne left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Small remark: It would be interesting to add ContactEveryone in the block .. versionadded:: 6.2 to respect the same logic as the others bridges.

@94noni
Copy link
Contributor

94noni commented Jul 17, 2022

Indeed the info should be added

@javiereguiluz javiereguiluz merged commit 4c04fd0 into symfony:6.2 Jul 18, 2022
@javiereguiluz
Copy link
Member

Thanks @zairigimad!

Thanks to reviewers too ... we added the new notifier to the versionadded directive while merging. Thanks!

@javiereguiluz javiereguiluz mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mdoutreluingne mdoutreluingne mdoutreluingne approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Notifier Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
5 participants
@zairigimad @94noni @javiereguiluz @mdoutreluingne @carsonbot