Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Allow configuring a target url when switching user #17024

Merged
merged 1 commit into from Sep 20, 2022

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Jul 21, 2022

Documents symfony/symfony#47343
Supersed symfony/symfony#46338 (feature changed)
Close #17021

@carsonbot carsonbot added this to the 6.2 milestone Jul 21, 2022
@xabbuh
Copy link
Member

xabbuh commented Jul 21, 2022

looking at the example configuration I wonder if being able to configure a route name wouldn't be more sensible in most cases than having to configure the URL (path)

@94noni
Copy link
Contributor Author

94noni commented Jul 22, 2022

looking at the example configuration I wonder if being able to configure a route name wouldn't be more sensible in most cases than having to configure the URL (path)

I see, I've inspired myself with the login default_target_path iirc

swapping to a route name, what changes will be necessary on the code side? injecting the router that's all?

@xabbuh
Copy link
Member

xabbuh commented Jul 22, 2022

swapping to a route name, what changes will be necessary on the code side? injecting the router that's all?

injecting a UrlGeneratorInterface should be enough, yes

@94noni
Copy link
Contributor Author

94noni commented Aug 16, 2022

@xabbuh got it

I’ll try to handle the code change in the next days, and then rewrite this doc entry

Status: needs work

@94noni
Copy link
Contributor Author

94noni commented Sep 13, 2022

I’ll try to handle the code change in the next days, and then rewrite this doc entry

its finally done @xabbuh :)
status: needs review

many thanks

@94noni
Copy link
Contributor Author

94noni commented Sep 18, 2022

I am afk so easier to accept suggested changes than using phone editor

@carsonbot carsonbot changed the title Allow configuring a target url when switching user [Security] Allow configuring a target url when switching user Sep 20, 2022
@javiereguiluz
Copy link
Member

Thanks Antoine.

@javiereguiluz javiereguiluz merged commit 4f5b7f3 into symfony:6.2 Sep 20, 2022
@94noni 94noni deleted the doc-switch-user-target-url branch September 20, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] Allow configuring a target url when switching user
6 participants