Skip to content

[Console] Add return for execute() #17176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2022
Merged

[Console] Add return for execute() #17176

merged 1 commit into from
Aug 15, 2022

Conversation

mohamedGasmii
Copy link
Contributor

Add return hint for execute() & add return Command::SUCCESS as return.

@mohamedGasmii
[Console] Add return hint
11b4dbd 
Add return hint for execute() & add return Command::SUCCESS as return.
@carsonbot carsonbot added this to the 5.4 milestone Aug 14, 2022
@xabbuh
Copy link
Member

xabbuh commented Aug 15, 2022

Thank you @mohamedGasmii.

@xabbuh xabbuh merged commit 3082fe5 into symfony:5.4 Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mohamedGasmii @xabbuh @carsonbot