Add hint about variables_order ini setting required #17267
Conversation
| ``.env`` files. | ||
| ``.env`` files. This behavior depends on | ||
| `variables_order <http://php.net/manual/en/ini.core.php#ini.variables-order>`_ to | ||
| contain an ``E`` to expose the ``$_ENV`` superglobal. |
There was a problem hiding this comment.
Friendly ping @stof @nicolas-grekas
There was a problem hiding this comment.
Yes, let's wait for their review because this change is really important, so we must be sure it's correct. Thanks!
There was a problem hiding this comment.
The Dotenv has a fallback reading from $_SERVER (for env variables not starting with HTTP_ to avoid security issues due to confusion with HTTP headers), but I'm not sure the CLI populates it. So it should support the case of not having E in the order as long as you don't rely on env variables starting with HTTP_
There was a problem hiding this comment.
@stof we've just received another user report from someone facing an issue because of this. So, I think we should merge this PR, unless you are against it. Thanks.
|
I think this change is fine. I recently faced an issue regarding the absence of the "E" on the |
|
Thanks @DracoBlue. Note: I merged this in |
I read about real environment variables always winning, when using dotenv - but my setup did not work like this. And I noticed that my variables_order ini setting was set to the default of debian production settings, which does not expose
$_ENVby default.Thus I added a sentence right behind stating that this depends on
$_ENVsuperglobal being filled, which also needs variables_order to contain an uppercaseE.