Skip to content

Conversation

ayacoo
Copy link
Contributor

@ayacoo ayacoo commented Oct 2, 2022

Related #17307

@carsonbot carsonbot added this to the 6.2 milestone Oct 2, 2022
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -342,6 +348,10 @@ method, which returns an instance of

A new line is appended automatically when displaying information in a section.

.. versionadded:: 6.2

Allow limiting the height of a console section was introduced in Symfony 6.2.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the following sentence fits better?

The ability to limit the height....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tweaked the message a bit while merging. Thanks.

@carsonbot carsonbot changed the title Update console.rst [Console] Update console.rst Oct 3, 2022
@javiereguiluz javiereguiluz merged commit a1eb2f2 into symfony:6.2 Oct 3, 2022
@javiereguiluz
Copy link
Member

Thanks @ayacoo for this contribution!

@ayacoo
Copy link
Contributor Author

ayacoo commented Oct 3, 2022

Thank you for your patience and support :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants