Skip to content

Update choice_translation_parameters.rst.inc #17354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2022
Merged

Update choice_translation_parameters.rst.inc #17354

merged 1 commit into from
Oct 15, 2022

Conversation

eerison
Copy link
Contributor

@eerison eerison commented Oct 15, 2022

Adding missing ";" for the choice_translation_parameters example

@eerison eerison requested a review from xabbuh as a code owner October 15, 2022 10:45
@carsonbot carsonbot added this to the 6.2 milestone Oct 15, 2022
mdoutreluingne
mdoutreluingne approved these changes Oct 15, 2022
View reviewed changes
Copy link
Contributor

@mdoutreluingne mdoutreluingne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
(note for the mergers: this can be merged in 5.4)

@javiereguiluz javiereguiluz modified the milestones: 6.2, 5.4 Oct 15, 2022
@eerison @javiereguiluz
Update choice_translation_parameters.rst.inc
c845048 
Adding missing ";" for the `choice_translation_parameters` example
@javiereguiluz javiereguiluz changed the base branch from 6.2 to 5.4 October 15, 2022 14:23
@javiereguiluz
Copy link
Member

Thank you Erison.

@javiereguiluz javiereguiluz merged commit 79e5249 into symfony:5.4 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

1 more reviewer

@mdoutreluingne mdoutreluingne mdoutreluingne approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@eerison @javiereguiluz @mdoutreluingne @carsonbot