Skip to content

[PHPUnitBridge] Correct time type return #17368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2022
Merged

[PHPUnitBridge] Correct time type return #17368

merged 1 commit into from
Oct 19, 2022

Conversation

fullbl
Copy link
Contributor

@fullbl fullbl commented Oct 19, 2022

time function returns an int, while DateTime::createFromFormat requires a string!

@javiereguiluz javiereguiluz added this to the 4.4 milestone Oct 19, 2022
@carsonbot carsonbot changed the title Correct time type return [PHPUnitBridge] Correct time type return Oct 19, 2022
@fullbl @javiereguiluz
Correct time type return
43e7043 
time function returns an int, while DateTime::createFromFormat requires a string!
@javiereguiluz javiereguiluz changed the base branch from 6.1 to 4.4 October 19, 2022 14:58
@javiereguiluz
Copy link
Member

Good catch, thanks @fullbl.

@javiereguiluz javiereguiluz merged commit 8e18cc7 into symfony:4.4 Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

@OskarStark OskarStark Awaiting requested review from OskarStark

Assignees
No one assigned
Labels
PHPUnitBridge Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fullbl @javiereguiluz @carsonbot