Skip to content

[Validator] Better wording #17525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2022
Merged

[Validator] Better wording #17525

merged 1 commit into from
Dec 8, 2022

Conversation

dragonito
Copy link
Contributor

Found once more. The other "to validate" in this text are fine.

@dragonito dragonito requested a review from xabbuh as a code owner December 6, 2022 18:26
@ThomasLandauer
Copy link
Contributor

"Allow to validate" isn't completely wrong, but "allow validating" is indeed better, see e.g. https://english.stackexchange.com/questions/60271/grammatical-complements-for-allow

@dragonito
Copy link
Contributor Author

"Allow to validate" isn't completely wrong, but "allow validating" is indeed better, see e.g.

Yes, you are right. "To Validate" is used frequently in the text, I just wanted to minimize the number a bit. Makes it easier to read.

@javiereguiluz javiereguiluz added this to the 5.4 milestone Dec 8, 2022
@carsonbot carsonbot changed the title Better wording [Validator] Better wording Dec 8, 2022
@javiereguiluz javiereguiluz changed the base branch from 6.2 to 5.4 December 8, 2022 11:04
@javiereguiluz
Copy link
Member

Thanks

@javiereguiluz javiereguiluz merged commit 8f0445b into symfony:5.4 Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Reviewed Validator
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@dragonito @ThomasLandauer @javiereguiluz @carsonbot