Skip to content

Some text improvements #17528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2022
Merged

Some text improvements #17528

merged 1 commit into from
Dec 8, 2022
+23 −23

Conversation

dragonito
Copy link
Contributor

Some text improvements, hope it helps

@javiereguiluz javiereguiluz added this to the 5.4 milestone Dec 8, 2022
@javiereguiluz javiereguiluz changed the base branch from 6.2 to 5.4 December 8, 2022 13:40
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner December 8, 2022 13:40
@javiereguiluz javiereguiluz merged commit 8bc359d into symfony:5.4 Dec 8, 2022
@javiereguiluz
Copy link
Member

Thanks Robin! This was a nice set of improvements. Please note that while merging I reverted the e.g. -> e.g., change for the reasons gave in the previous pull request. Thanks!

@dragonito
Copy link
Contributor Author

Sorry about the e.g.⇾e.g., I added this pr before I saw your comment. Next improvements / newer prs will be without comma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@dragonito @javiereguiluz @carsonbot