Tried to clarify that Bundle and AbstractBundle are different #17534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
reviewed
Dec 7, 2022
|
|
||
| .. caution:: | ||
|
|
||
| This is an alternative implementation to the above mentioned Bundle class. Bundle and AbstractBundle are not compatible. |
There was a problem hiding this comment.
I'd say after the first sentence something like...
You can use one of these approaches but not both at the same time.
that would make clearer what "not compatible" means in this context.
There was a problem hiding this comment.
Thx, I'm definitely not a native speaker :)
|
I'll open a new one against 6.1 |
|
#17536 Thx again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see https://stackoverflow.com/questions/74704768/invalidconfigurationexception-with-custom-bundle-in-symfony6-2 for the details.