[Clock] Add ClockSensitiveTrait to help write time-sensitive tests
#17771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
changed the title
OskarStark
reviewed
Jan 18, 2023
alexandre-daubois
changed the title
ClockSensitiveTrait to help write time-sensitive tests
alexandre-daubois
force-pushed
the
clocksensitivetesttrait
branch
from
77bf576 to
4d66c92
Compare
There was a problem hiding this comment.
Works for me but we might want to reword a few things when adding the final part, about #17605
alexandre-daubois
force-pushed
the
clocksensitivetesttrait
branch
from
4d66c92 to
b87b7b2
Compare
alexandre-daubois
force-pushed
the
clocksensitivetesttrait
branch
from
b87b7b2 to
d5860b1
Compare
OskarStark
approved these changes
Jan 19, 2023
|
Alex, thanks for another superb contribution! You are improving Clock docs a lot. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.