Skip to content

Conversation

alexandre-daubois
Copy link
Member

Fixes #16827

@javiereguiluz javiereguiluz added this to the 6.2 milestone Apr 11, 2023
@javiereguiluz javiereguiluz merged commit 9627986 into symfony:6.2 Apr 11, 2023
@javiereguiluz
Copy link
Member

Alex, thanks a lot for this contribution. The VarExporter component doesn't receive many doc PRs ... so we appreciate them a lot!

While merging we did some tweaks (see 013b6d1):

  • Adding the .. _instantiating-php-classes: reference is needed because we changed the headline, so the anchor link will change. This will "break" direct links to that section: https://symfony.com/doc/current/components/var_exporter.html#instantiating-php-classes (that's why we always add a hidden reference to the previous headline contents when we change them)
  • I reversed some changes in the comments that capitalized the first letter: // Creates ... vs // creates ... Of course your proposal is not wrong ... but we mostly use the second option because comments are usually one line and the capital letter looks unbalanced with the following code, which usually starts with a lowercase letter or the $ variable indicator. In the future we can discuss about changing this 🙏

Thanks!

@alexandre-daubois
Copy link
Member Author

Amazing, thanks @javiereguiluz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VarExporter] Add Hydrator::hydrate() and preserve PHP referenc…
4 participants