Skip to content

Change security title for checking if user is logged in #18036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2023
Merged

Change security title for checking if user is logged in #18036

merged 1 commit into from
Mar 11, 2023

Conversation

alamirault
Copy link
Contributor

Fix #18023

@carsonbot carsonbot added this to the 5.4 milestone Mar 9, 2023
artyuum
artyuum suggested changes Mar 10, 2023
View reviewed changes
@alamirault alamirault requested a review from artyuum March 10, 2023 18:55
@OskarStark OskarStark force-pushed the feature/18023-change-is-authenticated-title branch from 424152e to 4b5877c Compare March 11, 2023 09:39
@OskarStark
Copy link
Contributor

Thank you @alamirault.

@OskarStark OskarStark merged commit 4d64e82 into symfony:5.4 Mar 11, 2023
@alamirault alamirault deleted the feature/18023-change-is-authenticated-title branch March 11, 2023 13:38
@artyuum
Copy link
Contributor

artyuum commented Mar 22, 2023

Oops... I think there is a mistake here 😅
The issue was about changing IS_AUTHENTICATED_FULLY to IS_AUTHENTICATED.
Not sure how I missed that while reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

+1 more reviewer

@artyuum artyuum artyuum approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@alamirault @OskarStark @artyuum @carsonbot