Skip to content

Conversation

hbgamra
Copy link
Contributor

@hbgamra hbgamra commented Mar 18, 2023

Fix bug return type

@carsonbot carsonbot added this to the 6.3 milestone Mar 18, 2023
@OskarStark
Copy link
Contributor

Please create one big PR and target the lowest maintained branch, which is 5.4.

Thanks

@javiereguiluz
Copy link
Member

@hbgamra for he PRs that you have already opened, we can merge those. But, for future contributions, it's better to create a single PR with several of these changes 🙏 (but also, let's not make a huge PR with hundreds of changes). Thanks.

Fix bug return type
@javiereguiluz javiereguiluz changed the base branch from 6.3 to 5.4 March 22, 2023 14:32
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner March 22, 2023 14:32
@javiereguiluz javiereguiluz merged commit 24dc80c into symfony:5.4 Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants