Update serializer.rst #18273
Closed
Update serializer.rst #18273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constant 'ISO8601' is deprecated This format is not compatible with ISO-8601, but is left this way for backward compatibility reasons. Use DateTime::ATOM or DATE_ATOM for compatibility with ISO-8601 instead.
alamirault
reviewed
Oct 17, 2023
| @@ -724,7 +724,7 @@ When serializing, you can set a callback to format a specific object property:: | |||
|
|
|||
| // all callback parameters are optional (you can omit the ones you don't use) | |||
| $dateCallback = function ($innerObject, $outerObject, string $attributeName, string $format = null, array $context = []) { | |||
| return $innerObject instanceof \DateTime ? $innerObject->format(\DateTime::ISO8601) : ''; | |||
| return $innerObject instanceof \DateTime ? $innerObject->format(\DateTime::ATOM) : ''; | |||
There was a problem hiding this comment.
Expected output L746 must also be updated to 2014-03-22T09:43:12-05:00
|
Hi @alirezarahmani! Sorry for missing this contribution. In the meantime, we've rewritten the serializer documentation and I see we no longer mention ISO 8601 anywhere, so I'm going to close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constant 'ISO8601' is deprecated
This format is not compatible with ISO-8601, but is left this way for backward compatibility reasons. Use DateTime::ATOM or DATE_ATOM for compatibility with ISO-8601 instead.