Skip to content

Conversation

GaryPEGEOT
Copy link
Contributor

Fixes #18462

@javiereguiluz
Copy link
Member

Thanks Gary for contributing this!

While merging, we did some tweaks: 7f31c49

  1. We removed "defined" from the description because it's recommended to not include the worde being described in its own description (this is a bit confusing --> "defined [...] returns true if the env var is defined [...]")

  2. We renamed the env var of the example from NO_FOO to just FOO. I see the NO_COLOR example mentioned in the code PR, but using negated env vars makes the example harder to understand.

@GaryPEGEOT GaryPEGEOT deleted the patch-1 branch June 29, 2023 07:22
@GaryPEGEOT
Copy link
Contributor Author

Hi @javiereguiluz! Thanks! I think there's a small typo: #18465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DependencyInjection] Add defined prefix for env var processor
3 participants