[Form] Fix form data related events definition #18587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Jul 20, 2023
|
Jules, thanks for taking care of fixing obscure/complex bugs like this in the docs. |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Jul 21, 2023
This PR was merged into the 5.4 branch. Discussion ---------- [Form] Fix form events phpdocs | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | ~ Sibling of symfony/symfony-docs#18587. Commits ------- 2032b5b [Form] Fix form events phpdocs
symfony-splitter
pushed a commit
to symfony/form
that referenced
this pull request
Jul 21, 2023
This PR was merged into the 5.4 branch. Discussion ---------- [Form] Fix form events phpdocs | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | ~ Sibling of symfony/symfony-docs#18587. Commits ------- 2032b5bd8b [Form] Fix form events phpdocs
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PRE_SET_DATAevent is not safe to modify a form based on the data since the data can still be changed by listeners.POST_SET_DATAshould be used instead.