Skip to content

[Clock] Add $modifier argument to the now() helper #18771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2023
Merged

[Clock] Add $modifier argument to the now() helper #18771

merged 1 commit into from
Aug 28, 2023

Conversation

alexandre-daubois
Copy link
Member

Fix #18770

@carsonbot carsonbot added this to the 6.4 milestone Aug 21, 2023
94noni
94noni approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@94noni 94noni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$docPR = now("+6 hours");
😆

@javiereguiluz
Copy link
Member

Nice contribution. Thank you Alex!

@javiereguiluz javiereguiluz merged commit de0502e into symfony:6.4 Aug 28, 2023
OskarStark added a commit to OskarStark/symfony-docs that referenced this pull request Aug 29, 2023
@OskarStark
feature symfony#18771 [Clock] Add $modifier argument to the now() h…
4d66627 
…elper (alexandre-daubois)

This PR was merged into the 6.4 branch.

Discussion
----------

[Clock] Add $modifier argument to the `now()` helper

Fix symfony#18770

Commits
-------

30a2eed [Clock] Add $modifier argument to the `now()` helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

+1 more reviewer

@94noni 94noni 94noni approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Clock Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

[Clock] Add $modifier argument to the now() helper
5 participants
@alexandre-daubois @javiereguiluz @OskarStark @94noni @carsonbot