Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documention for signed URI expiration #19762

Merged
merged 1 commit into from Apr 12, 2024

Conversation

BaptisteContreras
Copy link
Contributor

@BaptisteContreras BaptisteContreras commented Apr 6, 2024

fixes #19684

I documented a new feature added in 7.1 for the URI signer.

I did not manage to build the doc locally to test, I followed the README but I got some errors on file I did not touch (like Found invalid reference "/components/expression_language" in file "workflow")

@carsonbot carsonbot added this to the 7.1 milestone Apr 6, 2024
@BaptisteContreras BaptisteContreras force-pushed the feature_19684 branch 4 times, most recently from 7dd04ec to 9fea8e0 Compare April 6, 2024 18:58
@BaptisteContreras BaptisteContreras changed the title [WIP] add documention for signed URI expiration [HttpFoundation] add documention for signed URI expiration Apr 6, 2024
@carsonbot carsonbot changed the title [HttpFoundation] add documention for signed URI expiration add documention for signed URI expiration Apr 6, 2024
routing.rst Show resolved Hide resolved
routing.rst Show resolved Hide resolved
@javiereguiluz javiereguiluz merged commit 14039a8 into symfony:7.1 Apr 12, 2024
3 checks passed
@javiereguiluz
Copy link
Member

Baptiste, thanks a lot for this contribution. I like the feature a lot. While merging I tweaked a bit your code example to only show the URI generation, not the URI checking parts (which were already explained above this).

Thanks and congrats on your first Symfony Docs contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HttpFoundation] Add temporary URI signed
4 participants