Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stopwatch] Add ROOT constant to make it easier to reference #19912

Merged
merged 1 commit into from
May 23, 2024
Merged

[Stopwatch] Add ROOT constant to make it easier to reference #19912

merged 1 commit into from
May 23, 2024

Conversation

alamirault
Copy link
Contributor

Fix #19907

Using constant is the best practice IMO

@carsonbot carsonbot added this to the 7.2 milestone May 22, 2024
@OskarStark
Copy link
Contributor

Thank you Antoine.

@OskarStark OskarStark merged commit cb331fb into symfony:7.2 May 23, 2024
3 checks passed
@alamirault alamirault deleted the feature/19907-root-constant branch May 26, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Stopwatch
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alamirault @OskarStark @carsonbot