Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Webhook] : update doc #19974

Open
wants to merge 1 commit into
base: 6.4
Choose a base branch
from
Open

[Webhook] : update doc #19974

wants to merge 1 commit into from

Conversation

alli83
Copy link
Contributor

@alli83 alli83 commented Jun 18, 2024

Update the webhook documentation

@alli83 alli83 marked this pull request as draft June 18, 2024 22:42
@carsonbot carsonbot added this to the 6.4 milestone Jun 18, 2024
@carsonbot carsonbot changed the title [WEBHOOK]: update doc [Webhook] : update doc Jun 18, 2024
alli83
alli83 commented Jun 18, 2024
View reviewed changes
webhook.rst
------------------------------------------------------------------

It is important to note that when the incoming webhook is processed by the :class:`WebhookController`, you have the option to handle the consumption of remote events asynchronously.
Indeed, this can be configured using a bus, with the default setting pointing to the Messenger component's default bus.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: show config

alli83
alli83 commented Jun 18, 2024
View reviewed changes
webhook.rst Outdated Show resolved Hide resolved
@javiereguiluz javiereguiluz mentioned this pull request Jun 19, 2024
Open
alli83
alli83 commented Jun 19, 2024
View reviewed changes
webhook.rst Outdated Show resolved Hide resolved
alli83
alli83 commented Jun 19, 2024
View reviewed changes
webhook.rst Show resolved Hide resolved
@alli83 alli83 force-pushed the webhook-update-doc branch 13 times, most recently from bb79ac4 to 581043f Compare June 19, 2024 13:16
@alli83 alli83 marked this pull request as ready for review July 1, 2024 07:20
kbond
kbond reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had time for a quick review of the first bit of this document.

I was a bit confused on "who was the consumer and who was the provider".

webhook.rst Outdated Show resolved Hide resolved
webhook.rst Outdated Show resolved Hide resolved
webhook.rst Outdated Show resolved Hide resolved
webhook.rst Outdated Show resolved Hide resolved
webhook.rst Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond left review comments

Assignees
No one assigned
Labels
Status: Needs Review Webhook
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alli83 @kbond @carsonbot