Skip to content

[Yaml] Minor fix when using the format option in the lint command #19993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2024
Merged

[Yaml] Minor fix when using the format option in the lint command #19993

merged 1 commit into from
Jun 27, 2024

Conversation

javiereguiluz
Copy link
Member

While reviewing #19991 I found this and I think it's an error.

@javiereguiluz javiereguiluz added this to the 5.4 milestone Jun 26, 2024
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner June 26, 2024 07:27
alexandre-daubois
alexandre-daubois approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@alexandre-daubois alexandre-daubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both syntax are supported, but having the = is more consistent with the rest of the doc 🙂

xabbuh
xabbuh approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, though the previous way should work as well.

@javiereguiluz javiereguiluz merged commit 4e9cd70 into symfony:5.4 Jun 27, 2024
@javiereguiluz javiereguiluz deleted the fix_format branch June 27, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

+1 more reviewer

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Status: Reviewed Yaml
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@javiereguiluz @OskarStark @xabbuh @alexandre-daubois @carsonbot