Skip to content

[Best Practices] Clarify not using the Config component for app configuration #20012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2024
Merged

[Best Practices] Clarify not using the Config component for app configuration #20012

merged 1 commit into from
Jul 17, 2024

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jul 2, 2024

Fix #20011

@wouterj wouterj mentioned this pull request Jul 2, 2024
Closed
@javiereguiluz
Copy link
Member

Thanks Wouter. I'm not merging this yet because in #20011 the discussion seems to be ongoing, so maybe we want to make other changes related to this. Thanks.

@javiereguiluz javiereguiluz added this to the 5.4 milestone Jul 16, 2024
@javiereguiluz
Copy link
Member

In addition to this PR, I propose #20044 to fully fix the original concerns of #20011. Thanks!

@javiereguiluz javiereguiluz changed the base branch from 7.1 to 5.4 July 17, 2024 15:50
@javiereguiluz
Copy link
Member

Thank you Wouter.

@javiereguiluz javiereguiluz merged commit 7d055f4 into symfony:5.4 Jul 17, 2024
@wouterj wouterj deleted the issue-20011 branch July 17, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@derrabus derrabus derrabus approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[Config] Purpose and Misusage of Component
4 participants
@wouterj @javiereguiluz @derrabus @carsonbot