added docs for PrependExtensionInterface #2007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| .. code-block:: xml | ||
|
|
||
| ???? |
There was a problem hiding this comment.
can someone tell me what i would need to write here?
There was a problem hiding this comment.
From what I can see, this should be:
<!-- app/config/config.xml -->
<?xml version="1.0" ?>
<container xmlns="http://symfony.com/schema/dic/services"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns:acme_hello="http://www.example.com/symfony/schema/"
xsi:schemaLocation="http://www.example.com/symfony/schema/ http://www.example.com/symfony/schema/hello-1.0.xsd">
<acme_something:config use_acme_goodbye="false">
<acme_something:entity_manager_name>non_default</acme_something:entity_manager>
</acme_something:config>
<acme_other:config use_acme_goodbye="false" />
</container>
| ------------------------------------------------ | ||
|
|
||
| An Extension can prepend the configuration of any Bundle before the ``load()`` | ||
| method is called by implementing ``PrependExtensionInterface``:: |
There was a problem hiding this comment.
This should be:
method is called by implementing
:class:`Symfony\\Component\\DependencyInjection\\Compiler\\PrependExtensionInterface`::
|
@johnkary thx, fixed the issue you noted. |
| } | ||
| } | ||
|
|
||
| Inside the ``prepend()`` method developers have full access to the ``ContainerBuilder`` instance |
There was a problem hiding this comment.
you should use the :method syntax to link to the phpdoc of the method
weaverryan
added a commit
that referenced
this pull request
Dec 26, 2012
added docs for PrependExtensionInterface
weaverryan
added a commit
that referenced
this pull request
Dec 26, 2012
…r links/notes to other sections
|
Hey Lukas! Merged in and a few tweaks made. Thanks for the docs, and nice feature! Cheers! |
weaverryan
added a commit
that referenced
this pull request
Dec 30, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see symfony/symfony#5566
most likely the wording needs to be tweaked. i am not sure if the example is clear enough either.