[2.1] Added caution about using is_granted in error pages #2079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| You **must not** use ``is_granted`` in your error pages, because the | ||
| router runs before the firewall. If the router throws an exception (for | ||
| instance, when the route does not match), the error page is not behind a | ||
| firewall and ``app.user`` is not defined. |
There was a problem hiding this comment.
app.user is defined (we cannot delete the method from the object). But it is null
weaverryan
added a commit
that referenced
this pull request
Jan 3, 2013
[2.1] Added caution about using is_granted in error pages
weaverryan
added a commit
that referenced
this pull request
Jan 3, 2013
|
Awesome! I've merged and tweaked slightly (tweak is more minor than it looks due to line break changes). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2078