[Validator] Add option to allow ANY protocol in Assert\Url constraint #21398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
approved these changes
Sep 23, 2025
javiereguiluz
force-pushed
the
fix_21397
branch
from
e6eed1a to
49cb38b
Compare
xabbuh
reviewed
Sep 24, 2025
|
|
||
| // allows all protocols whose names are RFC 3986 compliant | ||
| // (e.g. 'https://', 'git+ssh://', 'file://', 'custom://') | ||
| protocols: ['*'] |
There was a problem hiding this comment.
I wonder if we should allow '*' (so a string without the need to wrap it in an array)
xabbuh
reviewed
Sep 24, 2025
| protocols: ['*'] | ||
|
|
||
| // regular expressions are also valid | ||
| protocols: ['https?', 'custom.*', 'my-app-.*'] |
There was a problem hiding this comment.
Should we backport this to older branches?
There was a problem hiding this comment.
I don't follow you. Is this available in older branches? I thought it was a new feature added in 7.4.
There was a problem hiding this comment.
Maybe then this actually doesn't work at all? Because the only change I see in symfony/symfony#60561 is a strict comparison with ['*']. The remaining behaviour of the validator didn't change.
javiereguiluz
added a commit
that referenced
this pull request
Sep 24, 2025
…` option (xabbuh) This PR was merged into the 7.4 branch. Discussion ---------- [Validator] rework the usage of `'*'` for the `protocols` option following #21398, related to symfony/symfony#61826 Commits ------- 83a9025 rework the usage of '*' for the protocols option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21397.