Assetic #2263
Merged
Assetic #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| you can debug problems more easily. However, in the `prod` environment, this | ||
| will be rendered as a single `script` tag. | ||
| In the ``dev`` environment, each file is still served individually, so that | ||
| you can debug problems more easily. However, in the ``prod`` environment, |
There was a problem hiding this comment.
This is actually controlled by the debug flag, not by the environment
There was a problem hiding this comment.
and btw, this behavior can be changed as you can force assets to be always combined.
There was a problem hiding this comment.
Still, it is nice if the default behaviour is explained.
…ore details, evolving it
|
Thanks for the proofread @stof - I've updated with your change about the Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
This builds off of some changes in #1991, which addresses 2 issues:
a) Warning against using the
@MyBundlesyntax with CSS files (due to the rewrite filter). To my knowledge, this is still an issue with current versions of Symfony. If I'm wrong, please correct me :)b) adding a note about the
assetic.bundleskey - not included here, because this PR is against the 2.0 branch.But moreover, it's basically a re-read/refactor of the first half of the assetic docs. If anyone sees any errors or has any suggestions, please let me know!
This PR is against the 2.0 branch - after it is merged, we'll add a note about
assetic.bundleson 2.1.Thanks!