Removing class key/attribute from parents services in examples #2317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO, you should also keep an example where the class is inherited to show that it is possible (in case the different child services have the same class) |
| The parent service is abstract as it should not be directly retrieved from the | ||
| container or passed into another service. It exists merely as a "template" that | ||
| other services can use. This is why it has no ``class`` configured which would | ||
| cause an exception to be raised for a non-abstract service. |
There was a problem hiding this comment.
This sentence is wrong. an abstract service does not need to be an abstract class
There was a problem hiding this comment.
I was trying to make that point, I have made a change to hopefully make this clearer
|
@stof good call, I agree that it would be good to show using the parent service having a common class configured that could be inherited by other services. I think this should be a separate section that I will look at adding, |
weaverryan
added a commit
that referenced
this pull request
Mar 30, 2013
…mples Removing class key/attribute from parents services in examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the class defined on the parent service is misleading as this is not used for abstract services and also suggests that their must be a corresponding abstract class. Also changed some of the text that suggests the same thing.