Use the passed variable in the translated text. #2336
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍, but it should get merged into the |
weaverryan
added a commit
that referenced
this pull request
Mar 30, 2013
|
Hi Simon! I like what you've done here - the example is now much more complete. I've patched the commit into the 2.0 branch at sha: 58d3c57 - we'll merge it up through the rest of the branches from there. I also discovered some bad English here (not introduced with this fix), which was fixed at sha: aa7fde2 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's kind of strange to not use the passed variable in the example.