setValues() instead of setValue() #2420

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@xabbuh
Member
xabbuh commented Mar 30, 2013
Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #2412
@Sgoettschkes Sgoettschkes commented on the diff Mar 30, 2013
components/dom_crawler.rst
@@ -278,16 +278,17 @@ To work with multi-dimensional fields::
<input name="multi[dimensional]" />
</form>
-You must specify the fully qualified name of the field::
+You must specify the values of multi-dimensional fields as arrays itself to
+address which fields' values should be changed::
@Sgoettschkes
Sgoettschkes Mar 30, 2013 Contributor

I liked the old, short description better.

@xabbuh
xabbuh Mar 31, 2013 Member

I agree that it sounds better but it doesn't really match the code as you do not real fully qualified names. Any propositions for a better phrasing?

@weaverryan weaverryan added a commit that referenced this pull request Mar 31, 2013
@weaverryan weaverryan [#2420] Simplifying english e5814e6
@weaverryan
Member

Hey Christian!

I've patched this into the 2.0 branch at sha: f6d0476 and sha: e1be552. I also simplified the English in the description - I think the code below it is the most important: sha: e5814e6

Thanks!

@weaverryan weaverryan closed this Mar 31, 2013
@xabbuh xabbuh deleted the xabbuh:fix-set-values-instead-of-set-value branch May 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment