FaceLift of book/controller.rst issue #2377 and book/templating.rst issue #2379 #2423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -686,7 +686,7 @@ the ``notice`` message: | |||
|
|
|||
| .. code-block:: php | |||
|
|
|||
| <?php foreach ($view['session']->getFlash('notice') as $message): ?> | |||
| <?php foreach ($view['session']->getFlashBag('notice') as $message): ?> | |||
There was a problem hiding this comment.
This is wrong. getFlashBag is not a renaming of getFlash. It should be ->getFlashBag()->get('notice')
|
You're right. I have to édit. |
Ok for me, it seems to me that the behavior will change in hinclude with Twig but after checking it is not yet valid. Documentation visible symfony.com does not match perfectly with the master: in the case of the {% url render () ... but this is corrected on the master.
|
Hi Mickaël! A few things that you found were recently fixed, but I liked your Twig formatting change - I've patched that into the 2.1 branch at sha: 3ca1386 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.