add note on service parameters regarding ScopeWideningInjectionException #2424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| It can be useful to pass other services in as arguments to your custom service. | ||
| For example, you may want to pass in the `request` service as an argument. | ||
| In these cases, you may receive a `ScopeWideningInjectionException`. |
There was a problem hiding this comment.
you must use double backticks to indicate an inline code block
|
Oops, so hard to shake my Markdown brain. Fixed. |
| In these cases, you may receive a ``ScopeWideningInjectionException``. | ||
| To understand this problem better and learn how to solve it, refer to | ||
| the cookbook article :doc:`/cookbook/service_container/scopes` for a | ||
| few solutions. |
There was a problem hiding this comment.
I would delete "for a few solutions".
| @@ -231,6 +231,14 @@ looks up the value of each parameter and uses it in the service definition. | |||
|
|
|||
| <argument type="string">http://symfony.com/?foo=%%s&bar=%%d</argument> | |||
|
|
|||
| .. note:: | |||
There was a problem hiding this comment.
I think it should be a .. caution:: block
|
Hey Joel! Nice work here - and good use of existing documentation. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on our discussion in IRC, instead of describing how to use
strict=false, I linked to the cookbook article on Scopes for the recommended solutions.