Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][#2362] Documenting missing form options #2427

Closed
wants to merge 5 commits into from
Closed

[WIP][#2362] Documenting missing form options #2427

wants to merge 5 commits into from

Conversation

TheMelter
Copy link
Contributor

@TheMelter
Copy link
Contributor Author

Still need:
DateTime - widget
Field - data_class
Field - error_mapping

@weaverryan
Copy link
Member

Hey there!

This is an awesome start already. But for simplicity, I'm going to ask you to break the rules and base this off of the 2.1 branch. We're about to stop supporting the 2.0 branch, and since the field type is deprecated in 2.1, all the options you've added there will need to be moved to the form type. I think it might just be easier to start with 2.1 in this case :).

You should be able to rebase this branch to be based off of the 2.1 branch by running (this assumes upstream is connected to the symfony/symfony-docs repo):

git fetch upstream
git rebase --onto upstream/2.1 upstream/2.0 documenting_missing_form_variables

If you already knew that, apologies ;).

Thanks!

@weaverryan
Copy link
Member

ping @TheMelter!

@weaverryan
Copy link
Member

ping again @TheMelter

Thanks!

@weaverryan
Copy link
Member

Ping again @TheMelter! Let me know if you're able to continue this. At this point, 2.1 has reached end of maintenance, so this should be rebased on top of version 2.2.

Thanks!

weaverryan added a commit that referenced this pull request Jun 30, 2013
@weaverryan
Copy link
Member

Hey @TheMelter!

I've rebased this onto the 2.2 branch and merged it into 2.2 at the following commits:

Thanks for your work on this!

@weaverryan weaverryan closed this Jun 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants