Improved code of custom authentication provider cookbook article #2614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -233,6 +238,10 @@ the ``PasswordDigest`` header value matches with the user's password. | |||
| if (file_exists($this->cacheDir.'/'.$nonce) && file_get_contents($this->cacheDir.'/'.$nonce) + 300 > time()) { | |||
| throw new NonceExpiredException('Previously used nonce detected'); | |||
| } | |||
| // If cache directory does not exist we create it | |||
| if ( !is_dir($this->cacheDir) ) { | |||
There was a problem hiding this comment.
you have to remove the spaces between ()
| @@ -138,7 +138,7 @@ set an authenticated token in the security context if successful. | |||
| try { | |||
| $authToken = $this->authenticationManager->authenticate($token); | |||
|
|
|||
| $this->securityContext->setToken($authToken); | |||
| return $this->securityContext->setToken($authToken); | |||
There was a problem hiding this comment.
setToken does not return anything so this is misleading. You should put a return; statement after it instead.
weaverryan
added a commit
that referenced
this pull request
May 10, 2013
…on_provider Improved code of custom authentication provider cookbook article
|
Merged, thanks for your updates! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved source code of the article. Empty security Token and file_put_contents errors resolved.