Skip to content

Improve ISO references #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2013
Merged

Improve ISO references #3249

merged 2 commits into from
Dec 1, 2013

Conversation

bicpi
Copy link
Contributor

@bicpi bicpi commented Nov 30, 2013

Q A
Doc fix? yes
New docs? no
Applies to 2.2+
Fixed tickets -

Fix notations according to http://www.iso.org:

  • add missing space between ISO and the number
  • Alpha-2 > alpha-2

Constraints and Fields:

  • Country & Locale contraint and locale field type: Add ISO references and Wikipedia links
  • Language constraint: add Unicode language identifier hint as for the language field type

If anyone knows an official link to a listing of the Unicode language identifiers, please let me know.

weaverryan added a commit that referenced this pull request Dec 1, 2013
@weaverryan
Merge pull request #3249 from bicpi/improve_ISO_references
357f10b 
Improve ISO references
@weaverryan weaverryan merged commit 357f10b into symfony:2.2 Dec 1, 2013
@weaverryan
Copy link
Member

Nice work!

@bicpi bicpi deleted the improve_ISO_references branch January 5, 2014 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bicpi @weaverryan