Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing PHP syntax coloration #3633

Closed
wants to merge 1 commit into from
Closed

Conversation

DerekRoth
Copy link
Contributor

No description provided.

@xabbuh
Copy link
Member

xabbuh commented Mar 4, 2014

Thanks! 👍 For the next time, you can just push changes to the branch you used to create your pull request. This pull request will then be updated. Thus, you won't need to create a new one.

@xabbuh xabbuh mentioned this pull request Mar 5, 2014
@weaverryan
Copy link
Member

Thanks for the fast fix Derek - we only merged this a few days ago :). Cheers!

weaverryan added a commit that referenced this pull request Mar 5, 2014
This PR was submitted for the 2.4 branch but it was merged into the 2.3 branch instead (closes #3633).

Discussion
----------

Added missing PHP syntax coloration

Commits
-------

691f122 Added missing PHP syntax coloration
@weaverryan weaverryan closed this Mar 5, 2014
@xabbuh
Copy link
Member

xabbuh commented Mar 6, 2014

@weaverryan was it intended to close this issue without merging the fix? Or did I oversee something?

@weaverryan
Copy link
Member

@xabbuh when I have to switch the branch, the PR doesn't auto-close, so I close it manually after. You will still see the commit referenced here. I think in the core code it auto-closes, don't know what the difference is here :)

@xabbuh
Copy link
Member

xabbuh commented Mar 6, 2014

@weaverryan Sorry, this was my fault. I only looked at the file in the 2.4 branch. Did miss that you merged it into 2.3.

@stof
Copy link
Member

stof commented Mar 6, 2014

@weaverryan the commit message of the merge commit contains closes #3633, which will auto-close when the commit reaches the main branch (master).
And for the core, I don't think it auto-closes either for merges in older branches. I think @fabpot is closing manually (or more likely his merge script is doing the explicit close action after merging) to close without waiting the merge into newer branches

@weaverryan
Copy link
Member

@stof thanks for the clarification - I wasn't sure if I was missing something or not - apparently not!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants