[Console] Fix Console QuestionHelper $app to $this

[eko]

On QuestionHelper page, commands examples for calling getHelperSet use the following (where $app is undefined):

$app->getHelperSet()->get('question');

I've changed it to correct:

$this->getHelperSet()->get('question');

[cordoval]

true although you could have gotten the $app from $app = $this->getApplication(), also notice that $this->getApplication() is tagged @api so it is here to stay. But yeah this is a 👍

[wouterj]

👍 we never told what the $app variable contains, so it is confusing. Thanks for fixing it!

However, maybe changing it to $this->getHelper('question') is even better? (but that can be done in another PR too)

[eko]

Yes, it was confusing.

I've updated the PR to use $this->getHelper('...') instead of $this->getHelperSet()->get('...')

[cordoval]

👍

[weaverryan]

Hi guys!

Yes, this is much better. But, I need your help! Most of these changes apply to all versions (back to 2.3), but some (QuestionHelper) only apply to Symfony 2.5. Here's what we need to do:

1. Rebase this PR against the 2.3 branch (using rebase --onto...) or create a new PR against the 2.3 branch with only the 2.3 changes
2. Create a second PR with the 2.5-specific features.

@eko Can you help out with this?

Thanks!

[eko]

Hi @weaverryan,

Alright, I will create 2 new PRs against 2.3 and 2.5 branches in the week-end.

Thank you

[weaverryan]

Thanks @eko!

[eko]

Hi @weaverryan,

I've sent the 2 PRs against 2.3 and 2.5 branches:

• 2.3: [Console] Fix Console component getHelperSet()->get() to getHelper() #3993
• 2.5: [Console] Fix Console component $app to $this and use of getHelper() method #3994

So I think this PR can be closed?

Thank you