Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to standard edition #4500

Closed
wants to merge 1 commit into from
Closed

Link to standard edition #4500

wants to merge 1 commit into from

Conversation

harikt
Copy link
Contributor

@harikt harikt commented Nov 20, 2014

Q A
Doc fix? [yes]
New docs? [no]
Applies to [all]
Fixed tickets [N/A]

so users can get the app/AppKernel.php if needed.

@harikt harikt mentioned this pull request Nov 20, 2014
@harikt
Copy link
Contributor Author

harikt commented Nov 21, 2014

oh it seems I need to send to 2.3 branch ?

@weaverryan
Copy link
Member

@harikt It's ok, I can patch it in - so no worries!

@harikt
Copy link
Contributor Author

harikt commented Nov 21, 2014

@weaverryan thanks. Is this the way to contribute http://symfony.com/doc/current/contributing/documentation/overview.html ? Just learning.

@weaverryan
Copy link
Member

@harikt That's it! But we don't expect everyone to read all of that. If we spot something wrong, we (nicely) let you know :).

@harikt
Copy link
Contributor Author

harikt commented Nov 21, 2014

Thanks! .

Hari K T

You can ring me : +91 9388 75 8821

http://harikt.com , https://github.com/harikt ,
http://www.linkedin.com/in/harikt , http://www.xing.com/profile/Hari_KT

Skype : kthari85
Twitter : harikt

On Fri, Nov 21, 2014 at 8:43 AM, Ryan Weaver notifications@github.com
wrote:

@harikt https://github.com/harikt That's it! But we don't expect
everyone to read all of that. If we spot something wrong, we (nicely) let
you know :).


Reply to this email directly or view it on GitHub
#4500 (comment).

@wouterj
Copy link
Member

wouterj commented Nov 22, 2014

I'm not sure if I like this change though...

The section is only showing some basic features of Symfony2 and compares them to the current project set-up, to show that Symfony really makes your app more simple.

@harikt
Copy link
Contributor Author

harikt commented Nov 22, 2014

@wouterj if you go through the code it will be nice for people who are not familiar with distribution bundle to get linked to the file web/app.php . ie it.

If you don't like you can ignore and close the PR.

@weaverryan
Copy link
Member

Hmm, I see Wouter's point - @harikt I think you are probably not the average reader of this page - I would expect more beginners (but who knows!). Would it make sense to link to a page in the docs that shows you how to actually get your project started using the Symfony Standard Edition? Or would that not be helpful for what you were looking for @harikt?

Thanks!

@harikt
Copy link
Contributor Author

harikt commented Nov 22, 2014

@weaverryan

I would expect more beginners (but who knows!)

who knows who reads :-) . Just a suggestion if they don't know from where the

require_once __DIR__.'/../app/bootstrap.php';
require_once __DIR__.'/../app/AppKernel.php';

code comes.

May be after the heading The Sample Application in Symfony a link to install / configure symfony for the rest of the section? http://symfony.com/doc/current/book/from_flat_php_to_symfony2.html#the-sample-application-in-symfony

@wouterj
Copy link
Member

wouterj commented Feb 20, 2015

Hmm, I'm now liking it more than I did before. (I've read a bit more context this time). I'll label it as Finished and see if @weaverryan changed its mind too :)

@weaverryan
Copy link
Member

Yea, I agree with you Wouter. After a second look, it's just a nice link for more information in case you're curious. So, +1 - thanks @harikt!

@weaverryan weaverryan closed this Feb 24, 2015
weaverryan added a commit that referenced this pull request Feb 24, 2015
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #4500).

Discussion
----------

Link to standard edition

| Q             | A
| ------------- | ---
| Doc fix?      | [yes]
| New docs?     | [no]
| Applies to    | [all]
| Fixed tickets | [N/A]

so users can get the app/AppKernel.php if needed.

Commits
-------

030d7d6 Link to standard edition so users can get the app/AppKernel.php if needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants