-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to standard edition #4500
Link to standard edition #4500
Conversation
oh it seems I need to send to 2.3 branch ? |
@harikt It's ok, I can patch it in - so no worries! |
@weaverryan thanks. Is this the way to contribute http://symfony.com/doc/current/contributing/documentation/overview.html ? Just learning. |
@harikt That's it! But we don't expect everyone to read all of that. If we spot something wrong, we (nicely) let you know :). |
Thanks! . Hari K T You can ring me : +91 9388 75 8821 http://harikt.com , https://github.com/harikt , Skype : kthari85 On Fri, Nov 21, 2014 at 8:43 AM, Ryan Weaver notifications@github.com
|
I'm not sure if I like this change though... The section is only showing some basic features of Symfony2 and compares them to the current project set-up, to show that Symfony really makes your app more simple. |
@wouterj if you go through the code it will be nice for people who are not familiar with distribution bundle to get linked to the file If you don't like you can ignore and close the PR. |
Hmm, I see Wouter's point - @harikt I think you are probably not the average reader of this page - I would expect more beginners (but who knows!). Would it make sense to link to a page in the docs that shows you how to actually get your project started using the Symfony Standard Edition? Or would that not be helpful for what you were looking for @harikt? Thanks! |
who knows who reads :-) . Just a suggestion if they don't know from where the require_once __DIR__.'/../app/bootstrap.php';
require_once __DIR__.'/../app/AppKernel.php'; code comes. May be after the heading |
Hmm, I'm now liking it more than I did before. (I've read a bit more context this time). I'll label it as Finished and see if @weaverryan changed its mind too :) |
Yea, I agree with you Wouter. After a second look, it's just a nice link for more information in case you're curious. So, +1 - thanks @harikt! |
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #4500). Discussion ---------- Link to standard edition | Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [no] | Applies to | [all] | Fixed tickets | [N/A] so users can get the app/AppKernel.php if needed. Commits ------- 030d7d6 Link to standard edition so users can get the app/AppKernel.php if needed.
so users can get the app/AppKernel.php if needed.