New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cookbook] Custom compile steps on Heroku #5088

Merged
merged 1 commit into from May 3, 2015

Conversation

Projects
None yet
5 participants
@bicpi
Contributor

bicpi commented Mar 17, 2015

Q A
Doc fix? no
New docs? no
Applies to all
Fixed tickets #4217 (partially, list item 3)
{
"scripts": {
"compile": [
"app/console assetic:dump"

This comment has been minimized.

@javiereguiluz

javiereguiluz Mar 17, 2015

Member

Since we're talking about deploying apps into production, maybe we could add the --env=prod --no-debug options to this command?

@javiereguiluz

javiereguiluz Mar 17, 2015

Member

Since we're talking about deploying apps into production, maybe we could add the --env=prod --no-debug options to this command?

This comment has been minimized.

@bicpi

bicpi Mar 17, 2015

Contributor

The prod env is specified by the SYMFONY_ENV env variable in a section above. --no-debug should by set implicitly when using the prod env.

@bicpi

bicpi Mar 17, 2015

Contributor

The prod env is specified by the SYMFONY_ENV env variable in a section above. --no-debug should by set implicitly when using the prod env.

@bicpi

This comment has been minimized.

Show comment
Hide comment
@bicpi

bicpi Apr 30, 2015

Contributor

Anything's still missing in this PR?

Contributor

bicpi commented Apr 30, 2015

Anything's still missing in this PR?

@wouterj

This comment has been minimized.

Show comment
Hide comment
@wouterj

wouterj May 2, 2015

Member

@bicpi apart from a rebase, no

Member

wouterj commented May 2, 2015

@bicpi apart from a rebase, no

@bicpi

This comment has been minimized.

Show comment
Hide comment
@bicpi

bicpi May 2, 2015

Contributor

@wouterj Done, thanks for pointing out!

Contributor

bicpi commented May 2, 2015

@wouterj Done, thanks for pointing out!

@wouterj

This comment has been minimized.

Show comment
Hide comment
@wouterj

wouterj May 2, 2015

Member

Thanks! This is now labelled as finished

Member

wouterj commented May 2, 2015

Thanks! This is now labelled as finished

@weaverryan

This comment has been minimized.

Show comment
Hide comment
@weaverryan

weaverryan May 3, 2015

Member

WOW, this is very detailed - it's exactly the kind of stuff I was hoping for! Thanks Philipp!

Member

weaverryan commented May 3, 2015

WOW, this is very detailed - it's exactly the kind of stuff I was hoping for! Thanks Philipp!

@weaverryan weaverryan merged commit cb71ad0 into symfony:2.3 May 3, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

weaverryan added a commit that referenced this pull request May 3, 2015

feature #5088 [Cookbook] Custom compile steps on Heroku (bicpi)
This PR was merged into the 2.3 branch.

Discussion
----------

[Cookbook] Custom compile steps on Heroku

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | no
| Applies to    | all
| Fixed tickets | #4217 (partially, list item 3)

Commits
-------

cb71ad0 [Cookbook] Custom compile steps on Heroku
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment