Proofreading Javier's excellent updates - in some places, shortening some things #5304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| │ ├─ error.html.twig # All other HTML errors (including 500) | ||
| │ ├─ error404.json.twig | ||
| │ ├─ error403.json.twig | ||
| │ ├─ error.json.twig # All other JSON errors (including 500) |
There was a problem hiding this comment.
I don't it's usefull to show the line from app/, we don't do it for the sub dirs
| application is the fact that Symfony ignores them in the development environment | ||
| and displays the default exception pages instead. | ||
| Symfony shows the big *exception* page instead of your customized error page | ||
| when you're in the development environem |
There was a problem hiding this comment.
Actually, with the paragraph below, we can just remove this one completely I guess.
There was a problem hiding this comment.
yep - good catch, that was my intention!
|
👍 great work Ryan! This article is vey important, so the shorter and more actionable, the better :) |
weaverryan
added a commit
that referenced
this pull request
May 23, 2015
… shortening some things (weaverryan) This PR was merged into the 2.3 branch. Discussion ---------- Proofreading Javier's excellent updates - in some places, shortening some things | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | #5117 Hi guys! After @javiereguiluz's excellent updates in #5117, I proofread the first section (the most important one) even more. The big takeaway is that I tried to shorten some things - less talking, more showing (the original version was quite "long", Javier shortened some things, I'm proposing going even further). Thanks! Commits ------- 5dc0f36 Fixes thanks to the team ef97575 Proofreading Javier's excellent updates - in some places, shortening things even more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
After @javiereguiluz's excellent updates in #5117, I proofread the first section (the most important one) even more. The big takeaway is that I tried to shorten some things - less talking, more showing (the original version was quite "long", Javier shortened some things, I'm proposing going even further).
Thanks!