[Cookbook][Controller] few tweaks to the error pages article #5309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
May 24, 2015
xabbuh
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets |
| @@ -46,7 +46,7 @@ is used to render a Twig template to show the user. | |||
|
|
|||
| .. _cookbook-error-pages-by-status-code: | |||
|
|
|||
| This controller uses the HTTP status code, request format and the following | |||
| This controller uses the HTTP status code, the request format and the following | |||
There was a problem hiding this comment.
not sure if this is needed. For me (but maybe because I'm dutch), the original sentence is easier to read.
There was a problem hiding this comment.
Imho it reads odd the way it is now. If we omitted "the" here, we should remove it before "following logic" too. Let's see what Ryan thinks about this.
|
Let's merge this one. If @weaverryan disagrees with the added "the", he can always revert :) |
wouterj
added a commit
that referenced
this pull request
May 31, 2015
…cle (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Controller] few tweaks to the error pages article | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Commits ------- c7d1266 few tweaks to the error pages article
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.