Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text in index.html.twig for The Big Picture wrong #5338

Merged
merged 1 commit into from
May 31, 2015
Merged

Conversation

BT643
Copy link
Contributor

@BT643 BT643 commented May 29, 2015

Q A
Doc fix? yes
New docs? no
Applies to all

The text in the standard "index.html.twig" on "The Big Picture" documentation for the "Templates" section is wrong and needs updating.

The documentation shows: "

Welcome to Symfony!

" but the actual file (by default) has "Homepage.".

Nothing major but a bit misleading and confusing for a brand new user.

The text in the standard "index.html.twig" on "The Big Picture" documentation for the "Templates" section is wrong and needs updating.

The documentation shows: "<h1>Welcome to Symfony!</h1>" but the actual file (by default) has "Homepage.".

Nothing major but a bit misleading and confusing for a brand new user.
@xabbuh
Copy link
Member

xabbuh commented May 30, 2015

👍

@wouterj
Copy link
Member

wouterj commented May 31, 2015

Even these small things (especially in the Quick Tour) matter much. Thanks for keeping the code samples in sync @BT643!

@wouterj wouterj merged commit bdada47 into symfony:2.3 May 31, 2015
wouterj added a commit that referenced this pull request May 31, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

Text in index.html.twig for The Big Picture wrong

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all

The text in the standard "index.html.twig" on "The Big Picture" documentation for the "Templates" section is wrong and needs updating.

The documentation shows: "<h1>Welcome to Symfony!</h1>" but the actual file (by default) has "Homepage.".

Nothing major but a bit misleading and confusing for a brand new user.

Commits
-------

bdada47 Text in index.html.twig for The Big Picture wrong
@BT643
Copy link
Contributor Author

BT643 commented May 31, 2015

No problem @wouterj :) glad to be able to help while getting started with Symfony. No idea why I didn't start using it sooner!

@BT643 BT643 deleted the patch-2 branch May 31, 2015 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants