Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Finder] minor CS fix #5351

Merged
merged 1 commit into from
Jun 7, 2015
Merged

[Finder] minor CS fix #5351

merged 1 commit into from
Jun 7, 2015

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Jun 2, 2015

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets n/a

@xabbuh
Copy link
Member

xabbuh commented Jun 2, 2015

👍

@wouterj
Copy link
Member

wouterj commented Jun 6, 2015

I don't think it's a real CS fix. We use both quotes throughout the source and docs afaik.

@stof
Copy link
Member

stof commented Jun 6, 2015

@wouterj in the code, we use double quotes only when they are necessary to be able to use escape sequences (strings containing \n most of the time). Otherwise, the rule is to use single quotes everywhere (and PHP-CS-Fixer is fixing it for us in most places)

@wouterj
Copy link
Member

wouterj commented Jun 7, 2015

Thanks for the correction @stof. Let's merge it then, thanks Kévin!

@wouterj wouterj merged commit 6c8ac08 into symfony:2.3 Jun 7, 2015
wouterj added a commit that referenced this pull request Jun 7, 2015
@wouterj
minor #5351 [Finder] minor CS fix (dunglas)
560aa3e 
This PR was merged into the 2.3 branch.

Discussion
----------

[Finder] minor CS fix

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | n/a

Commits
-------

6c8ac08 [Finder] minor CS fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dunglas @xabbuh @wouterj @stof